-
Notifications
You must be signed in to change notification settings - Fork 337
Merge nested concat Ops optimization pass in ONNX dialect #3111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Arkar-Hema <[email protected]>
Signed-off-by: Arkar-Hema <[email protected]>
Signed-off-by: Arkar-Hema <[email protected]>
Signed-off-by: Arkar-Hema <[email protected]>
Signed-off-by: Arkar-Hema <[email protected]>
Signed-off-by: Arkar-Hema <[email protected]>
Can one of the admins verify this patch? |
Signed-off-by: Arkar-Hema <[email protected]>
Can one of the admins verify this patch? |
Can one of the admins verify this patch? |
Signed-off-by: Arkar-Hema <[email protected]>
Signed-off-by: Arkar-Hema <[email protected]>
Can one of the admins verify this patch? |
Signed-off-by: Arkar-Hema <[email protected]>
Can one of the admins verify this patch? |
Signed-off-by: Arkar-Hema <[email protected]>
Can one of the admins verify this patch? |
Signed-off-by: Arkar-Hema <[email protected]>
Can one of the admins verify this patch? |
Signed-off-by: Arkar-Hema <[email protected]>
Can one of the admins verify this patch? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with some minor changes!
Signed-off-by: Arkar-Hema <[email protected]>
Can one of the admins verify this patch? |
Signed-off-by: Arkar-Hema <[email protected]>
Can one of the admins verify this patch? |
Jenkins Linux ppc64le Build #15502 [push] Merge nested concat Ops ... started at 07:46 |
Jenkins Linux s390x Build #16521 [push] Merge nested concat Ops ... started at 07:46 |
Jenkins Linux amd64 Build #16519 [push] Merge nested concat Ops ... started at 06:46 |
Jenkins Linux amd64 Build #16519 [push] Merge nested concat Ops ... passed after 1 hr 29 min |
Jenkins Linux s390x Build #16521 [push] Merge nested concat Ops ... passed after 1 hr 41 min |
Jenkins Linux ppc64le Build #15502 [push] Merge nested concat Ops ... passed after 2 hr 30 min |
Concat merging
The RecomposeConcat pass is an ONNX-MLIR optimization pass that simplifies and merges ONNXConcatOp operations to improve model performance and reduce redundant operations.
The pass optimizes Concat operations by:
Input Representation
Original Flow (Nested Concat Operations)
Y=Concat(X1,Concat(X2,X3),X4)
Optimized Flow (Flattening Nested Concats)
Y=Concat(X1,X2,X3,X4)